Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients #28344

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Sep 3, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28125
License MIT
Doc PR -
@fabpot

fabpot approved these changes Sep 3, 2018

Show resolved Hide resolved src/Symfony/Bundle/FrameworkBundle/Client.php Outdated

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-export-client branch from 432bf05 to a468188 Sep 3, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

Looks like tests are broken with this change.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fix-export-client branch from a468188 to 2554554 Sep 4, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2018

Fixed, should be green soon.

@fabpot

fabpot approved these changes Sep 4, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 2554554 into symfony:2.8 Sep 4, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Sep 4, 2018

bug #28344 [HttpKernel][FrameworkBundle] Fix escaping of serialized p…
…ayloads passed to test clients (nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28125
| License       | MIT
| Doc PR        | -

Commits
-------

2554554 [HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fix-export-client branch Sep 4, 2018

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.