New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename AppVeyor filename #28345

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
4 participants
@Kocal
Contributor

Kocal commented Sep 3, 2018

Q A
Branch? 2.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

In AppVeyor documentation, it says that is possible to use alternative filename .appveyor.yml.

By doing this, I find this more consistent with Travis file which starts with a . too.

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Sep 3, 2018

@Kocal Kocal changed the title from chore: rename Appveyor filename to chore: rename AppVeyor filename Sep 3, 2018

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Sep 4, 2018

Member

Thank you @Kocal.

Member

fabpot commented Sep 4, 2018

Thank you @Kocal.

@fabpot fabpot merged commit b133bd6 into symfony:2.8 Sep 4, 2018

2 of 3 checks passed

fabbot.io Doing some proofreading and checking your coding style.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Sep 4, 2018

minor #28345 chore: rename AppVeyor filename (Kocal)
This PR was merged into the 2.8 branch.

Discussion
----------

chore: rename AppVeyor filename

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | ~   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | ~ <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

In [AppVeyor documentation](https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming), it says that is possible to use alternative filename `.appveyor.yml`.

By doing this, I find this more consistent with Travis file which starts with a `.` too.

Commits
-------

b133bd6 chore: rename Appveyor filename

@Kocal Kocal deleted the Kocal:chore/rename-appveyor-filename branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment