Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix dumping some complex service graphs #28366

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Copy link
Member

commented Sep 4, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28296 (and its duplicates #28355 & #28362 + possibly #28304)
License MIT
Doc PR -
@skalpa

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2018

It fixed it on my side. Thank you 👍

@FabienSalles

This comment has been minimized.

Copy link

commented Sep 5, 2018

It fixed it on my side too.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:di-fix branch from eca5db9 to 769fd4b Sep 5, 2018

@fabpot

fabpot approved these changes Sep 5, 2018

nicolas-grekas added a commit that referenced this pull request Sep 5, 2018

bug #28366 [DI] Fix dumping some complex service graphs (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix dumping some complex service graphs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28296 (and its duplicates #28355 & #28362 ~+ possibly #28304~)
| License       | MIT
| Doc PR        | -

Commits
-------

769fd4b [DI] Fix dumping some complex service graphs

@nicolas-grekas nicolas-grekas merged commit 769fd4b into symfony:3.4 Sep 5, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 5, 2018

Thank you @nicolas-grekas.

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix branch Sep 5, 2018

@XWB

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

I'm now getting other errors:

(1/1) ErrorExceptionNotice: Undefined variable: f
--
in srcDevDebugProjectContainer.php line 1786
(2/2) Twig_Error_Syntax
Unknown "abbr_class" filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.