Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[Form] Fix DateTimeType html5 input format #28372
Fix DateTimeType' HTML input format according to HTML specs. Currently
Also the reverseTransform was expect to have a timezone attached, which it does not - and incorrectly marks it as being a UTC time in this case, instead of using the Transformers output TZ.
7 times, most recently
Sep 5, 2018
referenced this pull request
Sep 7, 2018
This is a bit confusing:
@javiereguiluz I think in this case it is less a browser specific hack and more a more correct implementation of the datetime-local draft specs.
I think the whole idea of datetime-local is to be a datetime field without a timezone, this is also the description of the datetime-local field: https://www.w3.org/TR/2012/WD-html-markup-20120315/input.datetime-local.html
Also, when you see the reference of the date + time format (https://www.w3.org/TR/2012/WD-html-markup-20120315/datatypes.html#form.data.datetime-local) it clearly says that there should not be a timezone suffix.
I refered to the whatwg spec, which does not include
Sep 17, 2018
Could anyone please have a look at why this PR makes tests for 4.1 to fail?