Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fopen flags #28377

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
4 participants
@SpacePossum
Copy link
Contributor

commented Sep 6, 2018

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR none
@@ -1413,8 +1413,8 @@ private function resetProcessData()
$this->exitcode = null;
$this->fallbackStatus = array();
$this->processInformation = null;
$this->stdout = fopen('php://temp/maxmemory:'.(1024 * 1024), 'wb+');

This comment has been minimized.

Copy link
@SpacePossum

SpacePossum Sep 6, 2018

Author Contributor

wb+ is not valid

@@ -28,7 +28,7 @@ class CsvFileDumper extends FileDumper
*/
public function format(MessageCatalogue $messages, $domain = 'messages')
{
$handle = fopen('php://memory', 'rb+');

This comment has been minimized.

Copy link
@SpacePossum

SpacePossum Sep 6, 2018

Author Contributor

rb+ is not valid

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

Hello, can you rebase+retarget on 2.8 please, and also keep only the fixed modes?
The b is already the default mode since PHP4.soemthing, it is not needed to make it explicit.

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Sep 6, 2018

@SpacePossum SpacePossum force-pushed the SpacePossum:2_7_fopen_fixes branch from c81b923 to ae59908 Sep 6, 2018

@SpacePossum SpacePossum changed the base branch from 2.7 to 2.8 Sep 6, 2018

@SpacePossum

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2018

sure thing @nicolas-grekas 👍
leaves a very small PR though, sorry for that

@fabpot

fabpot approved these changes Sep 7, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

Thank you @SpacePossum.

@fabpot fabpot merged commit 6d155ed into symfony:2.8 Sep 7, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Sep 7, 2018

bug #28377 fix fopen flags (SpacePossum)
This PR was merged into the 2.8 branch.

Discussion
----------

fix fopen flags

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

<!--
Fixes the flags/mode used with `fopen`
-->

Commits
-------

6d155ed fix fopen calls

@SpacePossum SpacePossum deleted the SpacePossum:2_7_fopen_fixes branch Sep 7, 2018

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.