Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] fixed corrupt error output for unknown multibyte short option #28393

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
5 participants
@downace
Copy link
Contributor

commented Sep 7, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28320
License MIT
Doc PR -

[Console] Fixed #28320 by using mb_substr instead of index access

@chalasr
Copy link
Member

left a comment

thanks for contributing

Show resolved Hide resolved src/Symfony/Component/Console/Input/ArgvInput.php Outdated
Show resolved Hide resolved src/Symfony/Component/Console/Input/ArgvInput.php Outdated

@chalasr chalasr added this to the 2.8 milestone Sep 7, 2018

@chalasr

chalasr approved these changes Sep 8, 2018

@downace downace force-pushed the downace:ticket_28320 branch from 5794a6a to 867846b Sep 9, 2018

@javiereguiluz
Copy link
Member

left a comment

@downace a nice first contribution to Symfony. Thanks!

@chalasr chalasr force-pushed the downace:ticket_28320 branch from 9276547 to 0f86156 Sep 10, 2018

@chalasr

This comment has been minimized.

Copy link
Member

commented Sep 10, 2018

Thank you @downace.

@chalasr chalasr merged commit 0f86156 into symfony:2.8 Sep 10, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

chalasr added a commit that referenced this pull request Sep 10, 2018

bug #28393 [Console] fixed corrupt error output for unknown multibyte…
… short option (downace)

This PR was squashed before being merged into the 2.8 branch (closes #28393).

Discussion
----------

[Console] fixed corrupt error output for unknown multibyte short option

| Q             | A
| ------------- | ---
| Branch?       | 2.8 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28320   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

[Console] Fixed #28320 by using mb_substr instead of index access
<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

0f86156 [Console] fixed corrupt error output for unknown multibyte short option

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.