Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] Blacklist Eurozone and United Nations in Region Data Generator #28396

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
5 participants
@gregurco
Copy link
Contributor

commented Sep 7, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28260
License MIT
Doc PR -
@@ -34,6 +34,8 @@ class RegionDataGenerator extends AbstractDataGenerator
const BOUVET_ISLAND_ID = 'BV';
const HEARD_MCDONALD_ISLANDS_ID = 'HM';
const CLIPPERTON_ISLAND_ID = 'CP';
const EUROZONE_UNION_ID = 'EZ';

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Sep 8, 2018

Member

actually, this should be named EUROZONE_ID I suppose

This comment has been minimized.

Copy link
@gregurco

gregurco Sep 8, 2018

Author Contributor

fixed. I found in wiki that EZ is a monetary union, that's why I added union in constant name 🙂 but yep, finally it's not a usual "union".

@gregurco gregurco force-pushed the gregurco:2.8 branch from 6c0469c to b15c64c Sep 8, 2018

@nicolas-grekas nicolas-grekas force-pushed the gregurco:2.8 branch from b15c64c to e2e4049 Sep 9, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 9, 2018

Actually, the data also had to be updated. I just did it by pushing to your fork.

@stof

stof approved these changes Sep 10, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 10, 2018

Thank you @gregurco.

@nicolas-grekas nicolas-grekas merged commit e2e4049 into symfony:2.8 Sep 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Sep 10, 2018

bug #28396 [Intl] Blacklist Eurozone and United Nations in Region Dat…
…a Generator (gregurco)

This PR was merged into the 2.8 branch.

Discussion
----------

[Intl] Blacklist Eurozone and United Nations in Region Data Generator

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28260
| License       | MIT
| Doc PR        | -

Commits
-------

e2e4049 [Intl] Blacklist Eurozone and United Nations in Region Data Generator

@gregurco gregurco deleted the gregurco:2.8 branch Sep 10, 2018

@gregurco gregurco restored the gregurco:2.8 branch Sep 10, 2018

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.