Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controller][ServiceValueResolver] Making method access case insensitive #28404

Merged
merged 1 commit into from Sep 9, 2018

Conversation

Projects
None yet
5 participants
@nicoweb
Copy link
Contributor

commented Sep 8, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28254
License MIT
Doc PR -

Fix #28254 by making the method access insensitive in ServiceValueResolver.

@chalasr chalasr added this to the 3.4 milestone Sep 8, 2018

@nicoweb nicoweb force-pushed the nicoweb:fix_28254 branch from 11e5c56 to 35b86a7 Sep 8, 2018

@nicoweb nicoweb force-pushed the nicoweb:fix_28254 branch from 35b86a7 to cc6f827 Sep 8, 2018

@ostrolucky

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2018

Does this handle older AppBundle:Blog:list notation (notice no :: in there)?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 8, 2018

@ostrolucky the attached patch searches for only one : so it will work equally well with one or two :.
Also, I don't think the old notation ever hits the ServiceValueResolver: it is resolved before.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 9, 2018

Thank you @nicoweb.

@nicolas-grekas nicolas-grekas merged commit cc6f827 into symfony:3.4 Sep 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Sep 9, 2018

bug #28404 [Controller][ServiceValueResolver] Making method access ca…
…se insensitive (nicoweb)

This PR was merged into the 3.4 branch.

Discussion
----------

[Controller][ServiceValueResolver] Making method access case insensitive

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28254
| License       | MIT
| Doc PR        | -

Fix #28254 by making the method access insensitive in `ServiceValueResolver`.

Commits
-------

cc6f827 [Controller][ServiceValueResolver] Making method access case insensitive

@nicoweb nicoweb deleted the nicoweb:fix_28254 branch Sep 9, 2018

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.