Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] fix detecting overriden final/internal methods implemented using traits #28411

Merged
merged 1 commit into from Sep 9, 2018

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Sep 9, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Sep 9, 2018

@nicolas-grekas nicolas-grekas merged commit d638237 into symfony:3.4 Sep 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Sep 9, 2018

bug #28411 [Debug] fix detecting overriden final/internal methods imp…
…lemented using traits (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] fix detecting overriden final/internal methods implemented using traits

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

d638237 [Debug] fix detecting overriden final/internal methods implemented using traits

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:debug-trait-deprec branch Sep 9, 2018

nicolas-grekas added a commit that referenced this pull request Sep 22, 2018

bug #28553 [Debug] Fix false-positive "MicroKernelTrait::loadRoutes()…
…" method is considered internal" (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] Fix false-positive "MicroKernelTrait::loadRoutes()" method is considered internal"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes (fixing and unreleased issue)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28549
| License       | MIT
| Doc PR        | -

Introduced in #28411
Just a failing test for now.

Commits
-------

46c4f71 [Debug] Fix false-positive "MicroKernelTrait::loadRoutes()" method is considered internal"

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.