Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MonologBridge] Re-add option option to ignore empty context and extra data #28471

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
4 participants
@mpdude
Copy link
Contributor

commented Sep 14, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

In #11496, an option was added to ConsoleFormatter to ignore empty context and extra data. This setting was even turned on by default.

The ConsoleHandler was then overhauled in #21705. During this change, the option got lost.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

New feature, isn't it?

@nicolas-grekas nicolas-grekas requested a review from lyrixx Sep 18, 2018

@mpdude

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2018

@nicolas-grekas No, I’d say it restores a feature that was there before and accidentally got lost - see description.

@nicolas-grekas nicolas-grekas force-pushed the mpdude:ignore-empty-context-and-extra branch from 7565681 to d1e7438 Sep 20, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

Thank you @mpdude.

@nicolas-grekas nicolas-grekas merged commit d1e7438 into symfony:3.4 Sep 20, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Sep 20, 2018

bug #28471 [MonologBridge] Re-add option option to ignore empty conte…
…xt and extra data (mpdude)

This PR was squashed before being merged into the 3.4 branch (closes #28471).

Discussion
----------

[MonologBridge] Re-add option option to ignore empty context and extra data

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

In #11496, an option was added to `ConsoleFormatter` to ignore empty context and extra data. This setting was even turned on by default.

The `ConsoleHandler` was then overhauled in #21705. During this change, the option got lost.

Commits
-------

d1e7438 [MonologBridge] Re-add option option to ignore empty context and extra data
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

(would you mind checking where this would need to be mentioned in the doc please?)

@mpdude

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2018

@nicolas-grekas you mean the changelog or rather the symfony-docs?

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

The Symfony doc if possible.

@mpdude mpdude deleted the mpdude:ignore-empty-context-and-extra branch Sep 20, 2018

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.