Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] Implement startTest rather than startTestSuite #28495

Conversation

Projects
None yet
3 participants
@greg0ire
Copy link
Contributor

commented Sep 17, 2018

Passing a TestSuite instance to CoverageListenerTrait::testStart() will
have no effect.

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Closes #28481

@greg0ire greg0ire changed the title Implement startTest rather than startTestSuite [PhpUnitBridge] Implement startTest rather than startTestSuite Sep 17, 2018

Implement startTest rather than startTestSuite
Passing a TestSuite instance to CoverageListenerTrait::testStart() will
have no effect.

@greg0ire greg0ire force-pushed the greg0ire:implement_start_test_rather_than_start_suite branch from 0d6cfc7 to 63671d1 Sep 17, 2018

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Sep 18, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

Thank you @greg0ire.

@nicolas-grekas nicolas-grekas merged commit 63671d1 into symfony:3.4 Sep 18, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Sep 18, 2018

bug #28495 [PhpUnitBridge] Implement startTest rather than startTestS…
…uite (greg0ire)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Implement startTest rather than startTestSuite

Passing a TestSuite instance to CoverageListenerTrait::testStart() will
have no effect.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Closes #28481

Commits
-------

63671d1 Implement startTest rather than startTestSuite

@greg0ire greg0ire deleted the greg0ire:implement_start_test_rather_than_start_suite branch Sep 18, 2018

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.