Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intl] parse numbers terminated with decimal separator #28540

Merged
merged 1 commit into from Sep 22, 2018

Conversation

Projects
None yet
4 participants
@xabbuh
Copy link
Member

commented Sep 21, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28500
License MIT
Doc PR

@xabbuh xabbuh added this to the 2.8 milestone Sep 21, 2018

@xabbuh

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2018

The Intl extension's NumberFormatter class behaves this way: https://3v4l.org/C7c4h

@xabbuh xabbuh changed the base branch from master to 2.8 Sep 21, 2018

@xabbuh xabbuh added the Intl label Sep 21, 2018

@xabbuh xabbuh force-pushed the xabbuh:issue-28500 branch from cb1eb05 to 4225f36 Sep 21, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Sep 22, 2018

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 4225f36 into symfony:2.8 Sep 22, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Sep 22, 2018

bug #28540 [Intl] parse numbers terminated with decimal separator (xa…
…bbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

[Intl] parse numbers terminated with decimal separator

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28500
| License       | MIT
| Doc PR        |

Commits
-------

4225f36 parse numbers terminated with decimal separator

@xabbuh xabbuh deleted the xabbuh:issue-28500 branch Sep 22, 2018

This was referenced Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.