Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[Debug] Fix false-positive "MicroKernelTrait::loadRoutes()" method is considered internal" #28553
referenced this pull request
Sep 22, 2018
'@GuilhemN thanks a lot for having a look! Actually I don't agree with your patch, the test was fine and it's exactly why it was added in #28411. The issue is nastier: we don't deal with traits correctly. This very check you moved up shouldn't exist at all - and we should never inspect method annotations on traits.