Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] fix hidding warnings from session handlers #28562

Merged
merged 1 commit into from Sep 23, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Sep 23, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28467
License MIT
Doc PR -

The current logic is too greedy.

@fabpot

fabpot approved these changes Sep 23, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 23, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit f405b4d into symfony:3.4 Sep 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Sep 23, 2018

bug #28562 [HttpFoundation] fix hidding warnings from session handler…
…s (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] fix hidding warnings from session handlers

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28467
| License       | MIT
| Doc PR        | -

The current logic is too greedy.

Commits
-------

f405b4d [HttpFoundation] fix hidding warnings from session handlers

This was referenced Sep 30, 2018

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:session-warning branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.