Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation][Security] forward locale and format to subrequests #28565

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Sep 23, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28368, #21546
License MIT
Doc PR -

See discussion in linked issue.

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2018

(note that Request::duplicate() already preserves the format and the locale - but it's not the way the subrequest is created in these two spots.)

@fabpot

fabpot approved these changes Sep 26, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Sep 26, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 41eb191 into symfony:2.8 Sep 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Sep 26, 2018

bug #28565 [HttpFoundation][Security] forward locale and format to su…
…brequests (nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation][Security] forward locale and format to subrequests

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28368, #21546
| License       | MIT
| Doc PR        | -

See discussion in linked issue.

Commits
-------

41eb191 [HttpFoundation][Security] forward locale and format to subrequests

This was referenced Sep 30, 2018

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:subreq-locale branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.