Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Finder] fixed root directory access for ftp/sftp wrapper #28604

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
4 participants
@DerDu
Copy link
Contributor

commented Sep 26, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27423
License MIT
Doc PR symfony/symfony-docs#...

This fixes a flaw introduced in 3.4.7 by #26763

In order to access the root folder with ftp wrapper, there MUST BE a slash present.

  • Currently: from 3.4.7 on it just rtrim all seperators (/, \) from directories
  • Now: IF the directory is a (s)ftp:// wrapper (#^s?ftp://#) this fix just adds a slash (/) again
Show resolved Hide resolved src/Symfony/Component/Finder/Finder.php Outdated
@fabpot

fabpot approved these changes Oct 3, 2018

@fabpot fabpot force-pushed the DerDu:issue_27423 branch from b1cfcdb to 9630a38 Oct 3, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

Thank you @DerDu.

@fabpot fabpot merged commit 9630a38 into symfony:3.4 Oct 3, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Oct 3, 2018

bug #28604 [Finder] fixed root directory access for ftp/sftp wrapper …
…(DerDu)

This PR was squashed before being merged into the 3.4 branch (closes #28604).

Discussion
----------

[Finder] fixed root directory access for ftp/sftp wrapper

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27423
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This fixes a flaw introduced in 3.4.7 by #26763

In order to access the root folder with ftp wrapper, there MUST BE a slash present.
- Currently: from 3.4.7 on it just ```rtrim``` all seperators (```/```, ```\```) from directories
- Now: IF the directory is a (s)ftp:// wrapper (```#^s?ftp://#```) this fix just adds a slash (```/```) again

Commits
-------

9630a38 [Finder] fixed root directory access for ftp/sftp wrapper

This was referenced Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.