Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FWBundle] Throw if PropertyInfo is enabled, but the component isn't installed #28688

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
5 participants
@dunglas
Copy link
Member

commented Oct 2, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 2, 2018

@fabpot

fabpot approved these changes Oct 3, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

Thank you @dunglas.

@fabpot fabpot merged commit 41fd0a8 into symfony:3.4 Oct 3, 2018

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Oct 3, 2018

bug #28688 [FWBundle] Throw if PropertyInfo is enabled, but the compo…
…nent isn't installed (dunglas)

This PR was merged into the 3.4 branch.

Discussion
----------

[FWBundle] Throw if PropertyInfo is enabled, but the component isn't installed

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

41fd0a8 [FWBundle] Throw if PropertyInfo is enabled, but the component isn't installed

This was referenced Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.