Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] dont suggest hidden services in debug:container and debug:autow commands #28690

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Oct 2, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

spotted during a workshop at SymfonyLive London :)

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fwb-hide-cmd branch 2 times, most recently from 0b1ce94 to c293471 Oct 2, 2018

@chalasr

chalasr approved these changes Oct 2, 2018

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:fwb-hide-cmd branch from c293471 to 83f5dfb Oct 2, 2018

@fabpot

fabpot approved these changes Oct 3, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Oct 3, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 83f5dfb into symfony:4.1 Oct 3, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Oct 3, 2018

bug #28690 [FrameworkBundle] dont suggest hidden services in debug:co…
…ntainer and debug:autow commands (nicolas-grekas)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] dont suggest hidden services in debug:container and debug:autow commands

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

spotted during a workshop at SymfonyLive London :)

Commits
-------

83f5dfb [FrameworkBundle] dont suggest hidden services in debug:container and debug:autow commands

@fabpot fabpot referenced this pull request Oct 3, 2018

Merged

Release v4.1.6 #28707

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fwb-hide-cmd branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.