Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] fix dumping inline services again #28760

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Oct 8, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28720 #28710
License MIT
Doc PR -

The main fix is in PhpDumper::addInlineService()
Fixes a few other glitches found meanwhile.

$b->foo = $instance;
$a->bar = $b;

This comment has been minimized.

Copy link
@stof

stof Oct 9, 2018

Member

shouldn't we set this property earlier, to have the property set at the time of new \App\Foo($a) ?

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Oct 9, 2018

Author Member

It's important to set deps as late as possible, so that the consumer see them as populated as possible. The reason is that code usually expect it this way. The typical exemple is doctrine's configuration object, which must be fully defined before injection, so that consumers can use it immediately.

@nicolas-grekas nicolas-grekas merged commit a854b0a into symfony:3.4 Oct 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Oct 10, 2018

bug #28760 [DI] fix dumping inline services again (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] fix dumping inline services again

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28720 #28710
| License       | MIT
| Doc PR        | -

The main fix is in `PhpDumper::addInlineService()`
Fixes a few other glitches found meanwhile.

Commits
-------

a854b0a [DI] fix dumping inline services again

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-inline34 branch Oct 10, 2018

This was referenced Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.