Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] do not override custom access decision configs #28793

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
6 participants
@xabbuh
Copy link
Member

commented Oct 9, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28766
License MIT
Doc PR
@chalasr

chalasr approved these changes Oct 9, 2018

);
if (!isset($v['access_decision_manager'])) {
$v['access_decision_manager'] = array();
}

This comment has been minimized.

Copy link
@fabpot

fabpot Oct 10, 2018

Member

This part is not needed as PHP won't emit a notice when a directory is not defined and will happily create it on demand (line below).

This comment has been minimized.

Copy link
@xabbuh

xabbuh Oct 10, 2018

Author Member

indeed, updated

@xabbuh xabbuh force-pushed the xabbuh:issue-28766 branch from 3474f6c to 7743146 Oct 10, 2018

@fabpot

fabpot approved these changes Oct 10, 2018

@fabpot

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

Thank you @xabbuh.

@fabpot fabpot merged commit 7743146 into symfony:3.4 Oct 10, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Oct 10, 2018

bug #28793 [SecurityBundle] do not override custom access decision co…
…nfigs (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[SecurityBundle] do not override custom access decision configs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28766
| License       | MIT
| Doc PR        |

Commits
-------

7743146 do not override custom access decision configs

@xabbuh xabbuh deleted the xabbuh:issue-28766 branch Oct 10, 2018

This was referenced Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.