Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[WebProfilerBundle] Add channel log filter #28934
Continuation of #28906
The JS is revised to be more generic;
Level filter (works the same as shown in #28906 )
We forgot to update TwigBundle previously, that's still needed after review here.
6 times, most recently
Oct 20, 2018
Great work Roland! I've tested this in the Symfony Demo app. I only have minor remarks.
First: "Ghost filters": when loading the page, filters are displayed by default and they disappear when they shouldn't be displayed. This GIF shows a force reload in the page:
Maybe it's better to "hide by default" and display when appropriate?
Second: "Moving filters":
Right now, the multiple choice filters "move" under some circumstances. See hwen I deselect all of channels and icons disappear:
This kind of movements are distracting and user may click wrongly because of these element displacements. What if we replace the showing/hiding icon by a form checkbox? It doesn't have to be a real form, just a clickable checkbox. Stripe does something similar: