[FrameworkBundle] Added functional tests to prove multiple clients and client insulation. #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 16, 2011 14:30
|
I still have the exact same errors as before. |
|
Something must be corrupted in your gitrepo. Would you mind trying a fresh clone of symfony/symfony, then adding my remote |
fabpot
added a commit
that referenced
this pull request
Dec 17, 2011
Commits ------- 9b8cdab [FrameworkBundle] Prove client insulation and non-insulation works in session tests. ce66548 [FrameworkBundle] Add tests to prove functional testing works with simultaneous clients. ff0412a [FrameworkBundle] Small changes to test setup. Discussion ---------- [FrameworkBundle] Added functional tests to prove multiple clients and client insulation. Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - References: #2898 Todo: - @fabpot: I don't know what happened with the previous PR #2989 - seemed like some weird corruption as the tests passed locally and on travis except until after I fetched from the repo. I suspect something was corrupted. I asked @Seldaek to confirm the tests pass on his local setup before I submitted this PR. I only got rid of the errors locally after recloning the repo! http://travis-ci.org/#!/drak/symfony/builds/413515 [](http://travis-ci.org/drak/symfony?branch=frameworkbundle_moretests)
](http://travis-ci.org/drak/symfony?branch=frameworkbundle_moretests){kind=link}
|
Problem was the functional test bundle cache. |
|
Actually, the problem is that both 2.0 and master share the same cache for functional tests. This has been fixed here: f03692a |
|
Oh, nice catch fabpot! Thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
References: #2898
Todo: -
@fabpot: I don't know what happened with the previous PR #2989 - seemed like some weird corruption as the tests passed locally and on travis except until after I fetched from the repo. I suspect something was corrupted. I asked @Seldaek to confirm the tests pass on his local setup before I submitted this PR. I only got rid of the errors locally after recloning the repo!
http://travis-ci.org/#!/drak/symfony/builds/413515