New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean #29111

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@lyrixx
Member

lyrixx commented Nov 6, 2018

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Since the method should return a bool, then the default value should be
a bool too

[HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
Since the method should return a bool, then the default value should be
a bool too
@xabbuh

xabbuh approved these changes Nov 6, 2018

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Nov 6, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 6, 2018

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit 1fa5a9a into symfony:2.8 Nov 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 6, 2018

minor #29111 [HttpFoundation] Fixed PHP doc of ParameterBag::getBoole…
…an (lyrixx)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

Since the method should return a bool, then the default value should be
a bool too

Commits
-------

1fa5a9a [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean

@lyrixx lyrixx deleted the lyrixx:http-foundation-boolean branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment