New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change button_widget class to btn-primary #29115

Merged
merged 8 commits into from Nov 8, 2018

Conversation

@neFAST
Contributor

neFAST commented Nov 6, 2018

FIX #29114

Q A
Branch? master for features / 2.8 up to 4.1 for bug fixes
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29114
License MIT
Doc PR symfony/symfony-docs#...

Change button_widget class to btn-primary in Bootstrap 4 twig template

nicolas-grekas and others added some commits Nov 1, 2018

[HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
Since the method should return a bool, then the default value should be
a bool too
minor #29111 [HttpFoundation] Fixed PHP doc of ParameterBag::getBoole…
…an (lyrixx)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

---

Since the method should return a bool, then the default value should be
a bool too

Commits
-------

1fa5a9a [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
@xabbuh

As a bugfix for 3.4?

@xabbuh xabbuh dismissed their stale review Nov 7, 2018

looks like some tests are failing

@xabbuh

This comment has been minimized.

Member

xabbuh commented Nov 7, 2018

@neFAST Can you take a look at the failing tests?

@neFAST

This comment has been minimized.

Contributor

neFAST commented Nov 7, 2018

@xabbuh fixed

@xabbuh xabbuh added this to the 3.4 milestone Nov 8, 2018

@xabbuh

xabbuh approved these changes Nov 8, 2018

@xabbuh

This comment has been minimized.

Member

xabbuh commented Nov 8, 2018

@neFAST Thanks for your fast reaction. Nice contribution. 👍 IMO this is a bugfix so I have updated the description accordingly. Don't worry about the target branch. We can rebase your changes on the right branch while merging.

@dunglas

dunglas approved these changes Nov 8, 2018

nicolas-grekas and others added some commits Nov 8, 2018

bug #29057 [HttpFoundation] replace any preexisting Content-Type head…
…ers (nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpFoundation] replace any preexisting Content-Type headers

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21204
| License       | MIT
| Doc PR        | -

Commits
-------

de2ce58 [HttpFoundation] replace any preexisting Content-Type headers
Merge branch '2.8' into 3.4
* 2.8:
  [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
  [HttpFoundation] replace any preexisting Content-Type headers
bug #29131 [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS (ni…
…colas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Since using it is not thread safe, let's not rely on it (already done in other places.)

Commits
-------

21a909a [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS

@nicolas-grekas nicolas-grekas changed the base branch from master to 3.4 Nov 8, 2018

@nicolas-grekas nicolas-grekas force-pushed the neFAST:patch-1 branch from 94e79ce to 59003bf Nov 8, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 8, 2018

Thank you @neFAST.

@nicolas-grekas nicolas-grekas merged commit 59003bf into symfony:3.4 Nov 8, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 8, 2018

bug #29115 Change button_widget class to btn-primary (neFAST)
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29115).

Discussion
----------

Change button_widget class to btn-primary

FIX #29114

| Q             | A
| ------------- | ---
| Branch?       | master for features / 2.8 up to 4.1 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29114   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Change button_widget class to btn-primary in Bootstrap 4 twig template

Commits
-------

59003bf Change button_widget class to btn-primary

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

@fabpot fabpot referenced this pull request Nov 26, 2018

Merged

Release v3.4.19 #29334

@fabpot fabpot referenced this pull request Nov 26, 2018

Merged

Release v4.1.8 #29335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment