New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Cleaning translation commands and fix a bug for --all option #29128

Merged
merged 2 commits into from Nov 8, 2018

Conversation

Projects
None yet
4 participants
@yceruto
Contributor

yceruto commented Nov 7, 2018

Q A
Branch? master (4.2)
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29121 (comment)
License MIT
Doc PR -

@yceruto yceruto changed the title from [FrameworkBundle] Cleaning translation commands to [FrameworkBundle] Cleaning translation commands and fix a bug for --all option Nov 7, 2018

@fabpot

fabpot approved these changes Nov 8, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Nov 8, 2018

Thank you @yceruto.

@fabpot fabpot merged commit dfc7dcc into symfony:master Nov 8, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Nov 8, 2018

bug #29128 [FrameworkBundle] Cleaning translation commands and fix a …
…bug for --all option (yceruto)

This PR was squashed before being merged into the 4.2-dev branch (closes #29128).

Discussion
----------

[FrameworkBundle] Cleaning translation commands and fix a bug for --all option

| Q             | A
| ------------- | ---
| Branch?       | master (4.2)
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29121 (comment)
| License       | MIT
| Doc PR        | -

Commits
-------

dfc7dcc Also fix a bug for --all option
3cbefd8 Cleaning translation commands

@yceruto yceruto deleted the yceruto:cleaning_translation_commands branch Nov 8, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment