New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow][FrameworkBundle] fixed guard event names for transitions #29137

Open
wants to merge 2 commits into
base: 3.4
from

Conversation

Projects
None yet
4 participants
@lyrixx
Member

lyrixx commented Nov 8, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28018 #28007 (comment)
License MIT
Doc PR

There is a bug when many transitions are defined with the same name.
I finished destillat's work and rebase against 3.4 as it's a bug fix.

There another point of failure, but it could not be fixed on 3.4. I will
be a need feature. The issue is related to Workflow::can($subject, $transitionName).
Since the transitionName could be not unique, we will need to support
passing an instance of Transition. A new PR is incomming

@lyrixx lyrixx added the Workflow label Nov 8, 2018

@lyrixx lyrixx changed the title from [FrameworkBundle] fixed guard event names for transitions to [Workflow][FrameworkBundle] fixed guard event names for transitions Nov 8, 2018

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment