New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() #29154

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
5 participants
@chalasr
Member

chalasr commented Nov 9, 2018

Q A
Branch? 4.2
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28984, #29126
License MIT
Doc PR todo

Replaces #29126.

@chalasr chalasr added this to the 4.2 milestone Nov 9, 2018

@chalasr chalasr force-pushed the chalasr:cli-bootstrapenv branch from daae4af to bd47efa Nov 9, 2018

@chalasr chalasr changed the title from [Console] Add Application::bootstrapEnv() to [Console] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() Nov 9, 2018

@chalasr chalasr requested a review from nicolas-grekas Nov 9, 2018

@chalasr chalasr force-pushed the chalasr:cli-bootstrapenv branch from bd47efa to 6f4ee74 Nov 9, 2018

Show resolved Hide resolved UPGRADE-4.2.md Outdated
Show resolved Hide resolved UPGRADE-5.0.md Outdated
Show resolved Hide resolved src/Symfony/Component/Console/Application.php Outdated
Show resolved Hide resolved src/Symfony/Component/Console/Application.php Outdated
@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 9, 2018

Two more ideas:

  • add before/after for bin/console in UPGRADE files
  • bump symfony/console to 4.2 (in require-dev and conflict) so that we're sure to get console 4.2 when fwb 4.2 is installed (will make the recipe much simpler)

@chalasr chalasr force-pushed the chalasr:cli-bootstrapenv branch from 6f4ee74 to 428b3e4 Nov 9, 2018

@chalasr

This comment has been minimized.

Member

chalasr commented Nov 9, 2018

@nicolas-grekas updated, thanks

@nicolas-grekas

thanks!

@chalasr chalasr changed the title from [Console] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() to [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() Nov 9, 2018

@chalasr chalasr force-pushed the chalasr:cli-bootstrapenv branch from 428b3e4 to e3328a2 Nov 9, 2018

@chalasr chalasr added FrameworkBundle and removed Console labels Nov 9, 2018

@nicolas-grekas

OK, I agree, too opinionated for a component :)

@nicolas-grekas nicolas-grekas referenced this pull request Nov 9, 2018

Merged

fix namespace #484

@chalasr chalasr force-pushed the chalasr:cli-bootstrapenv branch from e3328a2 to bbd5682 Nov 10, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 10, 2018

I'm merging quickly so that the recipes work with 4.2 (they're broken for now.)
It will allow us to play with the new experience more easily to ensure 4.2 will be smooth.
If you have more comments here, please do post them and I'll ensure they're resolved asap.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 10, 2018

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit bbd5682 into symfony:master Nov 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 10, 2018

bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via A…
…pplication::bootstrapEnv() (chalasr)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28984, #29126
| License       | MIT
| Doc PR        | todo

Replaces #29126.

Commits
-------

bbd5682 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()

@chalasr chalasr deleted the chalasr:cli-bootstrapenv branch Nov 10, 2018

@fmata

This comment has been minimized.

Contributor

fmata commented Nov 10, 2018

I fixed a minor doc issue + removed \count() calls in #29164.

nicolas-grekas added a commit that referenced this pull request Nov 10, 2018

minor #29164 [FrameworkBundle] Application::bootstrapEnv() minor twea…
…ks (fmata)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[FrameworkBundle] Application::bootstrapEnv() minor tweaks

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Just 2 minor tweaks to #29154 caught while reviewing.

Commits
-------

4e92e6e [FrameworkBundle] Application::bootstrapEnv() upgrade doc fix

nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Nov 12, 2018

Revert "bug symfony#29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG …
…from argv via Application::bootstrapEnv() (chalasr)"

This reverts commit 9253199, reversing
changes made to 664a032.

nicolas-grekas added a commit that referenced this pull request Nov 13, 2018

bug #29197 Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DE…
…BUG from argv via Application::bootstrapEnv() (nicolas-grekas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv()

This reverts commit 9253199, reversing
changes made to 664a032.

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Replaced by symfony/recipes#491, see description there.

Commits
-------

f3c5fda Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() (chalasr)"

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment