New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] align IniFileLoader to PHP bugfix #76965 #29165

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 10, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Our CI is currently red because of the fix for https://bugs.php.net/76965
This fixes it by aligning the behavior to the fix in PHP core.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 10, 2018

@nicolas-grekas nicolas-grekas merged commit 0ab87f4 into symfony:3.4 Nov 10, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 10, 2018

bug #29165 [DI] align IniFileLoader to PHP bugfix #76965 (nicolas-gre…
…kas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] align IniFileLoader to PHP bugfix #76965

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Our CI is currently red because of the fix for https://bugs.php.net/76965
This fixes it by aligning the behavior to the fix in PHP core.

Commits
-------

0ab87f4 [DI] align IniFileLoader to PHP bugfix #76965

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-72 branch Nov 10, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

This was referenced Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment