New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Add hyperlinks support #29168

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
6 participants
@ostrolucky
Contributor

ostrolucky commented Nov 10, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21207
License MIT
Doc PR

For details about this see https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda

Here's one idea/use case which could utilize this feature (not implemented in this PR as it requires more work)
stack trace with anchors

I checked this in cmd.exe as well and no sideffects there

@enumag

This comment has been minimized.

Contributor

enumag commented Nov 10, 2018

Oh you actually went and figured it out. Great work @ostrolucky! 👍

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 10, 2018

Wow! We need this in CliDumper also!

@nicolas-grekas nicolas-grekas added this to the next milestone Nov 11, 2018

@Koc

This comment has been minimized.

Contributor

Koc commented Nov 12, 2018

Does it support framework.ide configuration option?

@ostrolucky

This comment has been minimized.

Contributor

ostrolucky commented Nov 12, 2018

This PR doesn't use this functionality, it only enables its usage. Screenshot was just potential scenario, it would require work outside the scope.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 15, 2018

Do we have any case where wrapping could need using the "id" attribute described in the linked doc?

@ostrolucky

This comment has been minimized.

Contributor

ostrolucky commented Nov 17, 2018

I don't

@ostrolucky ostrolucky force-pushed the ostrolucky:console-hyperlinks branch from e29f77b to 55ffa6e Nov 17, 2018

@nicolas-grekas

LGTM with one minor comment.
Can you please add a line in the changelog file of the component + create a doc issue/PR?

@fabpot

fabpot approved these changes Dec 10, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 10, 2018

@ostrolucky Can you submit a PR on the docs to document this new feature?

@fabpot fabpot force-pushed the ostrolucky:console-hyperlinks branch from f1d658d to db750ed Dec 10, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 10, 2018

Thank you @ostrolucky.

@fabpot fabpot merged commit db750ed into symfony:master Dec 10, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 10, 2018

feature #29168 [Console] Add hyperlinks support (ostrolucky)
This PR was squashed before being merged into the 4.3-dev branch (closes #29168).

Discussion
----------

[Console] Add hyperlinks support

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21207
| License       | MIT
| Doc PR        |

For details about this see https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda

Here's one idea/use case which could utilize this feature (not implemented in this PR as it requires more work)
![stack trace with anchors](https://user-images.githubusercontent.com/496233/48305600-00d4c300-e52e-11e8-94e6-33713ff09d50.png)

I checked this in cmd.exe as well and no sideffects there

Commits
-------

db750ed [Console] Add hyperlinks support

nicolas-grekas added a commit that referenced this pull request Dec 13, 2018

feature #29235 [VarDumper] add support for links in CliDumper (nicola…
…s-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[VarDumper] add support for links in CliDumper

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Same as #29168 for VarDumper:

![capture d ecran de 2018-11-15 20-10-08](https://user-images.githubusercontent.com/243674/48576196-24c04c00-e914-11e8-8a61-c1304c876243.png)

Thanks @ostrolucky for this nice discovery!

Commits
-------

e7cd44f [VarDumper] add support for links in CliDumper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment