New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Fix collecting uploaded files #29183

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
7 participants
@ro0NL
Contributor

ro0NL commented Nov 12, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29178
License MIT
Doc PR symfony/symfony-docs#...

@xabbuh xabbuh dismissed their stale review Nov 12, 2018

needs some more work

@gharlan

Thank you @ro0NL!

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Nov 12, 2018

Yes, all good now 👍

@ro0NL ro0NL force-pushed the ro0NL:upload branch from f2d3c4b to 61af43c Nov 12, 2018

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Nov 12, 2018

Per #29183 (comment)

logic should be rercursified.

status: needs work

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Nov 12, 2018

status: needs review

@javiereguiluz

Tested successfully in a 4.2-beta1 app. Thanks again Roland!

@xabbuh

xabbuh approved these changes Nov 12, 2018

@stof

This comment has been minimized.

Member

stof commented Nov 12, 2018

is this a bug affecting only 4.2 ?

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Nov 12, 2018

@stof yes

@stof

stof approved these changes Nov 12, 2018

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Nov 13, 2018

@nicolas-grekas nicolas-grekas force-pushed the ro0NL:upload branch from 8085314 to a439681 Nov 13, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 13, 2018

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit a439681 into symfony:master Nov 13, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 13, 2018

bug #29183 [HttpKernel] Fix collecting uploaded files (ro0NL)
This PR was squashed before being merged into the 4.2-dev branch (closes #29183).

Discussion
----------

[HttpKernel] Fix collecting uploaded files

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29178
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

a439681 [HttpKernel] Fix collecting uploaded files

@ro0NL ro0NL deleted the ro0NL:upload branch Nov 13, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment