New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Fix theme settings #29184

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
5 participants
@ro0NL
Contributor

ro0NL commented Nov 12, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28932 #28935
License MIT
Doc PR symfony/symfony-docs#...
@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Nov 12, 2018

Responsive:

image

@@ -1,6 +1,6 @@
<style>
#open-settings {
color: var(--text-muted);

This comment has been minimized.

@ro0NL

ro0NL Nov 12, 2018

Contributor

udefined var

@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Nov 12, 2018

Seems it fixes #28935 as well :)

@ro0NL ro0NL force-pushed the ro0NL:profiler branch from 80aff1d to 2b57726 Nov 12, 2018

@javiereguiluz

I've just tested this in a 4.2-beta1 app and it worked perfectly! Thanks a lot Roland.

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Nov 12, 2018

@nicolas-grekas nicolas-grekas force-pushed the ro0NL:profiler branch from bb14cb9 to 8fbe85c Nov 12, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 12, 2018

Thank you @ro0NL.

nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Nov 12, 2018

bug symfony#29184 [WebProfilerBundle] Fix theme settings (ro0NL)
This PR was squashed before being merged into the 4.2-dev branch (closes symfony#29184).

Discussion
----------

[WebProfilerBundle] Fix theme settings

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | symfony#28932 symfony#28935
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Commits
-------

8fbe85c [WebProfilerBundle] Fix theme settings

@nicolas-grekas nicolas-grekas merged commit 8fbe85c into symfony:master Nov 12, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

@ro0NL ro0NL deleted the ro0NL:profiler branch Nov 12, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment