New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug][HttpKernel] remove frames added by DebugClassLoader in stack traces #29190

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 12, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28818
License MIT
Doc PR -

image

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:debug-clear-loader branch from 2e7eaf6 to 76e7944 Nov 13, 2018

@j4nr6n

j4nr6n approved these changes Nov 15, 2018

Tested and working in my scratch project. Looks really good. 👍
image

@Tobion

This comment has been minimized.

Member

Tobion commented Nov 15, 2018

@j4nr6n the example you used is not affected by this change. This is about the deprecations coming from the DebugClassLoader which is not triggered in your example.

@fabpot

fabpot approved these changes Nov 16, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Nov 16, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 76e7944 into symfony:master Nov 16, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Nov 16, 2018

bug #29190 [Debug][HttpKernel] remove frames added by DebugClassLoade…
…r in stack traces (nicolas-grekas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Debug][HttpKernel] remove frames added by DebugClassLoader in stack traces

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28818
| License       | MIT
| Doc PR        | -

![image](https://user-images.githubusercontent.com/243674/48362054-14ee0100-e6a3-11e8-82e1-b185af45fb8b.png)

Commits
-------

76e7944 [Debug][HttpKernel] remove frames added by DebugClassLoader in stack traces

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:debug-clear-loader branch Nov 18, 2018

@stof stof modified the milestones: next, 4.2 Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment