New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] generate(null) should throw an exception #29191

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
5 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 12, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28634
License MIT
Doc PR -
@stof

stof approved these changes Nov 12, 2018

@xabbuh

xabbuh approved these changes Nov 12, 2018

@OskarStark

This comment has been minimized.

Contributor

OskarStark commented Nov 12, 2018

Should this be considered a BC break? I mean we currently don’t have a type hint here, so the behavior is changed.
I am 👍🏻 for this change but to have a smooth upgrade path without surprises, an Upgrade note should be added.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 12, 2018

3.4 throws already, that's a bug :)

@OskarStark

This comment has been minimized.

Contributor

OskarStark commented Nov 12, 2018

In this case... 👍🏻😉

@nicolas-grekas nicolas-grekas merged commit 710aafb into symfony:4.1 Nov 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 13, 2018

bug #29191 [Routing] generate(null) should throw an exception (nicola…
…s-grekas)

This PR was merged into the 4.1 branch.

Discussion
----------

[Routing] generate(null) should throw an exception

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28634
| License       | MIT
| Doc PR        | -

Commits
-------

710aafb [Routing] generate(null) should throw an exception

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:routing-fix-notice branch Nov 18, 2018

@fabpot fabpot referenced this pull request Nov 26, 2018

Merged

Release v4.1.8 #29335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment