Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Fix collecting messages #29196

Merged
merged 1 commit into from Nov 14, 2018
Merged

[Messenger] Fix collecting messages #29196

merged 1 commit into from Nov 14, 2018

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Nov 12, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no-ish
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

In 4.2 there's always one dispatched message because we provide the template with a generator. Calling {{ gen|length }} always returns 1

Before

image

After

image

@@ -117,13 +117,15 @@ public function getExceptionsCount(string $bus = null): int
return $count;
}

public function getMessages(string $bus = null): iterable
public function getMessages(string $bus = null): array
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getMessages() in 4.1

public function getMessages(string $bus = null): array

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change? the BC break is allowed and the new interface better, don't you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH, in order to "count" on the result. OK.

@nicolas-grekas
Copy link
Member

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit bfc7d94 into symfony:master Nov 14, 2018
nicolas-grekas added a commit that referenced this pull request Nov 14, 2018
This PR was merged into the 4.2-dev branch.

Discussion
----------

[Messenger] Fix collecting messages

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no-ish
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

In 4.2 there's always one dispatched message because we provide the template with a generator. Calling `{{ gen|length }}` always returns `1`

Before

![image](https://user-images.githubusercontent.com/1047696/48368788-f0028980-e6b4-11e8-91b0-54f755b9fb93.png)

After

![image](https://user-images.githubusercontent.com/1047696/48368817-0ad4fe00-e6b5-11e8-8215-54bfdb307c47.png)

Commits
-------

bfc7d94 [Messenger] Fix collecting messages
@ro0NL ro0NL deleted the messenger branch November 14, 2018 10:25
@fabpot fabpot mentioned this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants