New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options #29204

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
6 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 13, 2018

This reverts commit 9f60ff8.
This reverts commit 31b5615.

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28984
License MIT
Doc PR -

Working on recipes with @weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it.

Same as #29126, reverts #28745 and #28653

[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --…
…no-debug console options

This reverts commit 9f60ff8.
This reverts commit 31b5615.
@weaverryan

We were still trying to support these options via the bin/console file... but it required a lot of ugly, complex parsing. If we're going to support these options - and I think there are good use-cases for it - keeping it in core simplifies life elsewhere.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 14, 2018

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit 443f8ad into symfony:master Nov 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 14, 2018

bug #29204 [FrameworkBundle][WebServerBundle] Revert deprecation of -…
…-env and --no-debug console options (chalasr)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options

This reverts commit 9f60ff8.
This reverts commit 31b5615.

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28984
| License       | MIT
| Doc PR        | -

Working on recipes with @weaverryan, we figured out that this deprecation is just making our life more difficult. Let's revert it.

Same as #29126, reverts #28745 and #28653

Commits
-------

443f8ad [FrameworkBundle][WebServerBundle] Revert deprecation of --env and --no-debug console options

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:revert-env-deprecation branch Nov 14, 2018

@Tobion

This comment has been minimized.

Member

Tobion commented Nov 14, 2018

Do we need to reopen #23343 now?

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

@gggeek

This comment has been minimized.

gggeek commented on 443f8ad Nov 18, 2018

+1 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment