New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Fix remember-me cookie framework inheritance when session is disabled #29224

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
5 participants
@fbourigault
Contributor

fbourigault commented Nov 14, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29217
License MIT
Doc PR N/A

When framework.session configuration key is not an array, we ignore it.

@fbourigault

This comment has been minimized.

Contributor

fbourigault commented Nov 14, 2018

Does anyone know how to get the tests green without having to setup a kernel?

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Nov 14, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 14, 2018

(tests are red)

@fbourigault

This comment has been minimized.

Contributor

fbourigault commented Nov 14, 2018

(tests are red)

I know, but I don't know (yet) how to get green test suite. I'm still looking at the differences between 7.1 and 7.2 deps=low to find how to get green tests.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 14, 2018

cd src/Symfony/Bundle/SecurityBundle
composer up --prefer-lowest --prefer-stable
../../../../phpunit

@fbourigault fbourigault force-pushed the fbourigault:fix-rememberme-cookie-framework-inheritance branch from 406cfb0 to af81008 Nov 14, 2018

@fbourigault

This comment has been minimized.

Contributor

fbourigault commented Nov 14, 2018

AppVeyor build failure seems unrelated.

@xabbuh

xabbuh approved these changes Nov 15, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 15, 2018

Thank you @fbourigault.

@nicolas-grekas nicolas-grekas merged commit af81008 into symfony:master Nov 15, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 15, 2018

bug #29224 [SecurityBundle] Fix remember-me cookie framework inherita…
…nce when session is disabled (fbourigault)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[SecurityBundle] Fix remember-me cookie framework inheritance when session is disabled

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29217
| License       | MIT
| Doc PR        | N/A

When `framework.session` configuration key is not an array, we ignore it.

Commits
-------

af81008 [SecurityBundle] Fix remember-me cookie framework inheritance when session is disabled

@fbourigault fbourigault deleted the fbourigault:fix-rememberme-cookie-framework-inheritance branch Nov 15, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment