Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Added the condition routing option to the debug router command #29254

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
7 participants
@soufianZantar
Copy link
Contributor

soufianZantar commented Nov 18, 2018

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This PR will add the condition routing option to debug:router command, to show if a route have conditions or not and showing this conditions.

@OskarStark

This comment has been minimized.

Copy link
Contributor

OskarStark commented Nov 20, 2018

Thank you for your contribution.
Can you please show some output with a screenshot?

@soufianZantar

This comment has been minimized.

Copy link
Contributor Author

soufianZantar commented Nov 20, 2018

@OskarStark thank you for your review.
Yes, i will show you the output tonight (sadly i can't now).

@soufianZantar

This comment has been minimized.

Copy link
Contributor Author

soufianZantar commented Nov 20, 2018

Hi @OskarStark this is the srceenshots

bin/console debug:router routing_without_condition

routing-1

bin/console debug:router routing_with_condition

routing-2

bin/console debug:router --format=json

routing-3

bin/console debug:router --format=md

routing-4

bin/console debug:router --format=xml

routing-5

@soufianZantar soufianZantar force-pushed the soufianZantar:added_condition_to_debug_router branch 2 times, most recently from 56cf697 to 2fdd7e5 Nov 22, 2018

@soufianZantar

This comment has been minimized.

Copy link
Contributor Author

soufianZantar commented Nov 22, 2018

hi @ro0NL
I have added your suggestion, what you think now?

and why AppVeyor return Command exited with code -1073741819? all tests was passed, is that normal?

@ro0NL

ro0NL approved these changes Nov 23, 2018

Copy link
Contributor

ro0NL left a comment

failures unrelated

@soufianZantar soufianZantar force-pushed the soufianZantar:added_condition_to_debug_router branch from 2fdd7e5 to 0b2d9f4 Dec 14, 2018

@fabpot

fabpot approved these changes Mar 4, 2019

@fabpot fabpot force-pushed the soufianZantar:added_condition_to_debug_router branch from 0b2d9f4 to 92bdc9b Mar 4, 2019

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Mar 4, 2019

Thank you @soufianZantar.

@fabpot fabpot merged commit 92bdc9b into symfony:master Mar 4, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
fabbot.io Some changes should be done to comply with our standards.
Details

fabpot added a commit that referenced this pull request Mar 4, 2019

feature #29254 [FrameworkBundle] Added the condition routing option t…
…o the debug router command (soufianZantar)

This PR was squashed before being merged into the 4.3-dev branch (closes #29254).

Discussion
----------

[FrameworkBundle] Added the condition routing option to the debug router command

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        |  <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->
This PR will add the condition routing option to debug:router command, to show if a route have conditions or not and showing this conditions.

Commits
-------

92bdc9b [FrameworkBundle] Added the condition routing option to the debug router command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.