Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undeprecate the single-colon notation for controllers #29386

Conversation

@fbourigault
Copy link
Contributor

fbourigault commented Nov 30, 2018

Q A
Branch? 4.1
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

This is the same as #29218 but for Symfony\Bundle\FrameworkBundle\Routing\DelegatingLoader.

@stof

This comment has been minimized.

Copy link
Member

stof commented Nov 30, 2018

hmm, I forgot we had this deprecation in 2 places...

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Dec 1, 2018

Thank you @fbourigault.

@nicolas-grekas nicolas-grekas merged commit 09371ad into symfony:4.1 Dec 1, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
nicolas-grekas added a commit that referenced this pull request Dec 1, 2018
…urigault)

This PR was merged into the 4.1 branch.

Discussion
----------

undeprecate the single-colon notation for controllers

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

This is the same as #29218 but for `Symfony\Bundle\FrameworkBundle\Routing\DelegatingLoader`.

Commits
-------

09371ad undeprecate the single-colon notation for controllers
@fbourigault fbourigault deleted the fbourigault:undeprecate-single-colon-controller-notation branch Dec 1, 2018
This was referenced Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.