New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][Messenger] Restore check for messenger serializer default id #29395

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
4 participants
@ogizanagi
Member

ogizanagi commented Nov 30, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets https://symfony-devs.slack.com/archives/C9PQ75TV3/p1543590611003500
License MIT
Doc PR N/A

From Slack:

@adamquaile [4:10 PM]
So, I just updated to 4.2 today, and got this message:

The default Messenger serializer cannot be enabled as the Serializer support is not available. Try enabling it or running "composer require symfony/serializer-pack"

In the docs it's stated:

In order to use Symfony's built-in AMQP transport, you will need the Serializer Component. Ensure that it is installed with:

But I haven't yet configured AMQP - I'm using my own transport. Should I be getting this exception?


This check was removed in #28405, but is actually still necessary to not fail as soon as you can install the Messenger component without the Serializer one installed.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 1, 2018

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 1cf17c0 into symfony:4.2 Dec 1, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 1, 2018

bug #29395 [FrameworkBundle][Messenger] Restore check for messenger s…
…erializer default id (ogizanagi)

This PR was merged into the 4.2 branch.

Discussion
----------

[FrameworkBundle][Messenger] Restore check for messenger serializer default id

| Q             | A
| ------------- | ---
| Branch?       | 4.2 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |  https://symfony-devs.slack.com/archives/C9PQ75TV3/p1543590611003500  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

From Slack:

> @adamquaile [4:10 PM]
> So, I just updated to 4.2 today, and got this message:
> > The default Messenger serializer cannot be enabled as the Serializer support is not available. Try enabling it or running "composer require symfony/serializer-pack"
>
> In the docs it's stated:
> > In order to use Symfony's built-in AMQP transport, you will need the Serializer Component. Ensure that it is installed with:
>
>But I haven't yet configured AMQP - I'm using my own transport. Should I be getting this exception?

---
This check was removed in #28405, but is actually still necessary to not fail as soon as you can install the Messenger component without the Serializer one installed.

Commits
-------

1cf17c0 [FrameworkBundle][Messenger] Restore check for messenger serializer default id

@ogizanagi ogizanagi deleted the ogizanagi:fix/fwb-messenger-default-serializer branch Dec 1, 2018

@fabpot fabpot referenced this pull request Dec 6, 2018

Merged

Release v4.2.1 #29493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment