New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type for $value in DocBlock #29396

Merged
merged 1 commit into from Dec 1, 2018

Conversation

Projects
None yet
4 participants
@rudidude86
Contributor

rudidude86 commented Dec 1, 2018

$value is supposed to be a string, not an int, according to NumberFormatter::setTextAttribute() documentation

Q A
Branch? master for features / 3.4 up to 4.2 for bug fixes
Bug fix? yes/no
New feature? yes/no
BC breaks? no
Deprecations? yes/no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...
@ro0NL

This comment has been minimized.

Contributor

ro0NL commented Dec 1, 2018

Hi @rudidude86 can you rebase on 3.4? We should fix bugs on the lowest maintained branch.

fix type for $value in DocBlock
`$value` is supposed to be a string, not an int, according to [`NumberFormatter::setTextAttribute()` documentation](https://secure.php.net/manual/en/numberformatter.settextattribute.php)

@nicolas-grekas nicolas-grekas changed the base branch from master to 3.4 Dec 1, 2018

@nicolas-grekas nicolas-grekas force-pushed the rudidude86:patch-1 branch from 63f7010 to ff2431a Dec 1, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 1, 2018

Thank you @rudidude86.

@nicolas-grekas nicolas-grekas merged commit ff2431a into symfony:3.4 Dec 1, 2018

0 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

nicolas-grekas added a commit that referenced this pull request Dec 1, 2018

minor #29396 fix type for $value in DocBlock (rudidude86)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #29396).

Discussion
----------

fix type for $value in DocBlock

`$value` is supposed to be a string, not an int, according to [`NumberFormatter::setTextAttribute()` documentation](https://secure.php.net/manual/en/numberformatter.settextattribute.php)

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
| Bug fix?      | yes/no
| New feature?  | yes/no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

ff2431a fix type for $value in DocBlock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment