Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[FrameworkBundle][Controller] Use interface from Contracts to remove deprecation arnings #29398
When we installed 4.2, we hit issues in our qa tools with vimeo/psalm reporting that all of our controllers were implementing a deprecated interface (by extending the AbstractController).
This pr simply updates the AbstractController to use the interface provided in
I'm not sure if there was any other reason for not including this in the 4.2 release (bc?), so apologies if I've overstepped this.
LGTM for 4.2
There is a theoretical BC break here when one does
instanceof ServiceSubscriberInterface on a controller - but nobody does that.
We might also consider this as a false positive from psalm (it should ignore same-vendor usage of deprecated interfaces - knowing that in the generic case, fixing this is a BC break.)