New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix dumping expressions accessing single-use private services #29414

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
3 participants
@chalasr
Member

chalasr commented Dec 1, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29403
License MIT
Doc PR n/a

Introduced in #27268, see fixed ticket

@chalasr chalasr added this to the 4.2 milestone Dec 1, 2018

@chalasr chalasr force-pushed the chalasr:expr-inline-call branch 2 times, most recently from bda7e66 to 3f2be01 Dec 1, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 1, 2018

I changed L602 recently and I think it should be reverted as it's a very local workaround. Can you have a look please?

@nicolas-grekas nicolas-grekas reopened this Dec 1, 2018

@chalasr chalasr force-pushed the chalasr:expr-inline-call branch from 3f2be01 to 0d12d93 Dec 1, 2018

@chalasr

This comment has been minimized.

Member

chalasr commented Dec 1, 2018

@chalasr chalasr force-pushed the chalasr:expr-inline-call branch from 0d12d93 to e05f8c0 Dec 1, 2018

@nicolas-grekas nicolas-grekas changed the base branch from 4.2 to 3.4 Dec 2, 2018

@nicolas-grekas nicolas-grekas force-pushed the chalasr:expr-inline-call branch from e05f8c0 to d1e84aa Dec 2, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 2, 2018

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit d1e84aa into symfony:3.4 Dec 2, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 2, 2018

bug #29414 [DI] Fix dumping expressions accessing single-use private …
…services (chalasr)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix dumping expressions accessing single-use private services

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29403
| License       | MIT
| Doc PR        | n/a

Introduced in #27268, see fixed ticket

Commits
-------

d1e84aa [DI] Fix dumping expressions accessing single-use private services

@nicolas-grekas nicolas-grekas modified the milestones: 4.2, 3.4 Dec 2, 2018

@chalasr chalasr deleted the chalasr:expr-inline-call branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment