New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] Split form field heading #29415

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
3 participants
@ro0NL
Contributor

ro0NL commented Dec 1, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

By default the data class 9/10 breaks inline, making it harder to read. This fixes it.

Before

image

After

image

@ro0NL ro0NL force-pushed the ro0NL:form-profiler branch from 148bf6a to 3855d5a Dec 1, 2018

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Dec 1, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 2, 2018

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit 3855d5a into symfony:3.4 Dec 2, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 2, 2018

minor #29415 [WebProfilerBundle] Split form field heading (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[WebProfilerBundle] Split form field heading

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

By default the data class 9/10 breaks inline, making it harder to read. This fixes it.

Before

![image](https://user-images.githubusercontent.com/1047696/49332204-02cbf800-f5a9-11e8-8565-f0f084fa76dd.png)

After

![image](https://user-images.githubusercontent.com/1047696/49332202-f47ddc00-f5a8-11e8-8a97-80f002c9bfc2.png)

Commits
-------

3855d5a [WebProfilerBundle] Split form field heading

@ro0NL ro0NL deleted the ro0NL:form-profiler branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment