New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] dont inline when lazy edges are found #29432

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
2 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 2, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29412, #29391
License MIT
Doc PR -

I'm not able to create a reproducer to hit this situation, but on 4.2, this check makes the difference.
I'm merging to fix the issue as that's still the proper fix.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Dec 2, 2018

@nicolas-grekas nicolas-grekas merged commit 484c49e into symfony:3.4 Dec 2, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 2, 2018

bug #29432 [DI] dont inline when lazy edges are found (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] dont inline when lazy edges are found

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29412, #29391
| License       | MIT
| Doc PR        | -

I'm not able to create a reproducer to hit this situation, but on 4.2, this check makes the difference.
I'm merging to fix the issue as that's still the proper fix.

Commits
-------

484c49e [DI] dont inline when lazy edges are found

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-inline branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment