New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Fixed BC break for Workflow metadata #29444

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
4 participants
@lyrixx
Member

lyrixx commented Dec 3, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29427
License MIT
Doc PR

I used SplObjectStorage to store the transition metadata.
So we need to use the exact same PHP Object.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 3, 2018

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas merged commit 5691818 into symfony:4.1 Dec 3, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 3, 2018

bug #29444 [Workflow] Fixed BC break for Workflow metadata (lyrixx)
This PR was merged into the 4.1 branch.

Discussion
----------

[Workflow] Fixed BC break for Workflow metadata

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29427
| License       | MIT
| Doc PR        |

I used SplObjectStorage to store the transition metadata.
So we need to use the exact same PHP Object.

Commits
-------

5691818 [Workflow] Fixed BC break for Workflow metadata
$this->assertInstanceOf(Definition::class, $params[0]);
$this->assertSame(Workflow\Transition::class, $params[0]->getClass());
$this->assertSame(array('submit', 'start', 'travis'), $params[0]->getArguments());
$this->assertSame(array('title' => 'transition submit title'), $params[1]);

This comment has been minimized.

@alexislefebvre

alexislefebvre Dec 3, 2018

Contributor

Can we keep the test of array('title' => 'transition submit title')?

This comment has been minimized.

@lyrixx

lyrixx Dec 4, 2018

Member

No. It's not an instance of transition anymore

@lyrixx lyrixx deleted the lyrixx:workflow-metadata branch Dec 4, 2018

This was referenced Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment