New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Fixed grouped composite constraints #29499

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
5 participants
@HeahDude
Copy link
Member

HeahDude commented Dec 7, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17675, #25888, #23480
License MIT
Doc PR ~

From Lisbon :). Thanks @stof, @xabbuh for your help to finally fix this old issue.

@xabbuh

xabbuh approved these changes Dec 7, 2018

@stof

stof approved these changes Dec 7, 2018

@stof

This comment has been minimized.

Copy link
Member

stof commented Dec 8, 2018

Thanks @HeahDude.

@stof stof merged commit b53d911 into symfony:3.4 Dec 8, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

stof added a commit that referenced this pull request Dec 8, 2018

bug #29499 [Validator] Fixed grouped composite constraints (HeahDude)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Fixed grouped composite constraints

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17675, #25888, #23480
| License       | MIT
| Doc PR        | ~

From Lisbon :). Thanks @stof, @xabbuh for your help to finally fix this old issue.

Commits
-------

b53d911 [Validator] Fixed grouped composite constraints

@HeahDude HeahDude deleted the HeahDude:validation-groups-collection branch Dec 8, 2018

@backbone87

This comment has been minimized.

Copy link
Contributor

backbone87 commented Dec 10, 2018

I think this change completely obsoletes the caching. I am not sure, but a constraint that has two grps would now be validated twice, if the both grps are the validation target.

@xabbuh

This comment has been minimized.

Copy link
Member

xabbuh commented Dec 10, 2018

Most constraints don't extend the Composite constraint so are not affected here.

@backbone87

This comment has been minimized.

Copy link
Contributor

backbone87 commented Dec 12, 2018

Yes you are right, i was desperately searching for the check for Composites, while its right the line above.

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment