New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] filter out invalid Intl values #29500

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
5 participants
@xabbuh
Copy link
Member

xabbuh commented Dec 7, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23679
License MIT
Doc PR

@xabbuh xabbuh added this to the 3.4 milestone Dec 7, 2018

@HeahDude
Copy link
Member

HeahDude left a comment

We miss other choice fields that rely on the same optimized implementation.

@xabbuh xabbuh force-pushed the xabbuh:issue-23679-3.4 branch from 7c15267 to a2d6940 Dec 8, 2018

@xabbuh xabbuh changed the title [Form] filter out invalid language values [Form] filter out invalid Intl values Dec 8, 2018

@stof

stof approved these changes Dec 8, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Dec 8, 2018

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit a2d6940 into symfony:3.4 Dec 8, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 8, 2018

bug #29500 [Form] filter out invalid Intl values (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] filter out invalid Intl values

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23679
| License       | MIT
| Doc PR        |

Commits
-------

a2d6940 filter out invalid Intl values

@xabbuh xabbuh deleted the xabbuh:issue-23679-3.4 branch Dec 8, 2018

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment