New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument #29513

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
6 participants
@karser
Copy link
Contributor

karser commented Dec 8, 2018

Q A
Branch? 3.4 and up to 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28825
License MIT

This is a fix of #28825 big thanks @dunglas and @xabbuh

@stof

This comment has been minimized.

Copy link
Member

stof commented Dec 8, 2018

#SymfonyConHackday2018

@dunglas

dunglas approved these changes Dec 8, 2018

@chalasr chalasr added this to the 3.4 milestone Dec 9, 2018

@fabpot

fabpot approved these changes Dec 10, 2018

[Hackday][Serializer] Deserialization ignores argument type hint from…
… phpdoc for array in constructor argument

@fabpot fabpot force-pushed the karser:3.4-deserialize-nested-array-of-objects-bug branch from f552109 to 8741d00 Dec 10, 2018

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 10, 2018

Thank you @karser.

@fabpot fabpot merged commit 8741d00 into symfony:3.4 Dec 10, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 10, 2018

bug #29513 [Hackday][Serializer] Deserialization ignores argument typ…
…e hint from phpdoc for array in constructor argument (karser)

This PR was squashed before being merged into the 3.4 branch (closes #29513).

Discussion
----------

[Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument

| Q             | A
| ------------- | ---
| Branch?       | 3.4 and up to 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28825
| License       | MIT

This is a fix of #28825 big thanks @dunglas and @xabbuh

Commits
-------

8741d00 [Hackday][Serializer] Deserialization ignores argument type hint from phpdoc for array in constructor argument

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment