New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBridge][Form] Prevent multiple rendering of form collection prototypes #29527

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
5 participants
@Shoplifter
Copy link
Contributor

Shoplifter commented Dec 8, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29489
License MIT

prevents attemt to render of prototype in CollectionType when it has been rendered already.
(see Deprecated calling FormRenderer::searchAndRenderBlock for fields which were already rendered.)

@xabbuh

xabbuh approved these changes Dec 8, 2018

@xabbuh xabbuh added this to the 3.4 milestone Dec 8, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Dec 8, 2018

Please update the PR + commit titles to a standalone self-describing and short one. Please also add the target component in square brackets.

@Shoplifter Shoplifter changed the title fix for issue https://github.com/symfony/symfony/issues/29489 Open [TwigBridge][Form] Dec 8, 2018

@Shoplifter Shoplifter changed the title Open [TwigBridge][Form] [TwigBridge][Form] Prevent multiple rendering of form collection prototypes Dec 8, 2018

@Shoplifter Shoplifter force-pushed the Shoplifter:ticket_29489 branch from 89be763 to ef0b44e Dec 10, 2018

@Shoplifter Shoplifter requested review from dunglas , lyrixx and sroze as code owners Dec 10, 2018

@nicolas-grekas nicolas-grekas force-pushed the Shoplifter:ticket_29489 branch from ef0b44e to ffd2722 Dec 12, 2018

@nicolas-grekas nicolas-grekas changed the base branch from 4.2 to 3.4 Dec 12, 2018

@nicolas-grekas

This comment has been minimized.

Copy link
Member

nicolas-grekas commented Dec 12, 2018

Thank you @Shoplifter.

@nicolas-grekas nicolas-grekas merged commit ffd2722 into symfony:3.4 Dec 12, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 12, 2018

bug #29527 [TwigBridge][Form] Prevent multiple rendering of form coll…
…ection prototypes (Shoplifter)

This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge][Form] Prevent multiple rendering of form collection prototypes

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29489   <!-- #-prefixed issue number(s), if any -->
| License       | MIT

prevents attemt to render of prototype in CollectionType when it has been rendered already.
(see [Deprecated calling FormRenderer::searchAndRenderBlock for fields which were already rendered.](https://github.com/symfony/symfony/blob/master/UPGRADE-4.2.md#form))

Commits
-------

ffd2722 [TwigBridge][Form] Prevent multiple rendering of form collection prototypes

@Shoplifter Shoplifter deleted the Shoplifter:ticket_29489 branch Dec 12, 2018

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment