New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Added IBAN format for Vatican City State #29531

Merged
merged 1 commit into from Dec 9, 2018

Conversation

Projects
None yet
4 participants
@raulfraile
Copy link
Contributor

raulfraile commented Dec 8, 2018

IBAN for Vatican City State was added to IBAN registry recently. This PR adds support for this new format in the Iban validator.

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT
@ostrolucky

This comment has been minimized.

Copy link
Contributor

ostrolucky commented Dec 8, 2018

I think patches like these are treated as bugfixes, so should be targetting 3.4

@@ -5,6 +5,7 @@ CHANGELOG
-----

* added options `iban` and `ibanPropertyPath` to Bic constraint
* added support for Vatican City State IBAN format

This comment has been minimized.

@fabpot

fabpot Dec 8, 2018

Member

Should be removed when rebased on 3.4 (as this should indeed be considered as a bug fix).

@raulfraile raulfraile changed the base branch from master to 3.4 Dec 9, 2018

@raulfraile raulfraile changed the base branch from 3.4 to master Dec 9, 2018

@raulfraile raulfraile force-pushed the raulfraile:feature/iban-vatican-city branch from 2374ce9 to d169bf0 Dec 9, 2018

@raulfraile raulfraile changed the base branch from master to 3.4 Dec 9, 2018

@raulfraile

This comment has been minimized.

Copy link
Contributor

raulfraile commented Dec 9, 2018

@fabpot thanks for the comments! It's now rebased and targetting 3.4

@fabpot

fabpot approved these changes Dec 9, 2018

@fabpot fabpot force-pushed the raulfraile:feature/iban-vatican-city branch from 7826734 to 5f02614 Dec 9, 2018

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Dec 9, 2018

Thank you @raulfraile.

@fabpot fabpot merged commit 5f02614 into symfony:3.4 Dec 9, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 9, 2018

bug #29531 [Validator] Added IBAN format for Vatican City State (raul…
…fraile)

This PR was squashed before being merged into the 3.4 branch (closes #29531).

Discussion
----------

[Validator] Added IBAN format for Vatican City State

IBAN for Vatican City State was added to [IBAN registry](https://www.swift.com/sites/default/files/resources/iban_registry.pdf) recently. This PR adds support for this new format in the `Iban` validator.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

5f02614 [Validator] Added IBAN format for Vatican City State

This was referenced Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment